Skip to content

fix(sdk): enforce safe install boundaries - #26

Merged
samzong merged 2 commits into
mainfrom
fix/safe-install-boundaries
Aug 10, 2026
Merged

fix(sdk): enforce safe install boundaries#26
samzong merged 2 commits into
mainfrom
fix/safe-install-boundaries

Conversation

@samzong

@samzong samzong commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

What's changed?

  • Validate skill names and host adapter paths before resolving filesystem targets.
  • Fail closed on invalid ownership metadata and empty application IDs.
  • Stage installs atomically with unique hidden directories and consistent modes across SDKs.
  • Extend shared golden cases and runtime gates for unsafe paths, metadata, atomic failure, concurrency, and permissions.

Why

  • Prevent path escapes, unsafe overwrite or removal, partial installs, and staging collisions while preserving cross-language parity.

Verification

  • node scripts/check.mjs
  • TypeScript, Go, Rust, and Python golden suites under umask 077

Signed-off-by: samzong <samzong.lu@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0de05c3beb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ts/src/index.ts
Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong

samzong commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 595b19875d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread python/src/kitup/_metadata.py
@samzong
samzong merged commit 494698d into main Aug 10, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant