fix: align glossary entries with rendered ui labels - #1065
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
RiskeyL
reviewed
Sep 28, 2026
RiskeyL
left a comment
Contributor
There was a problem hiding this comment.
Verified both rows at dify 0c5f2507, the EE rc30 pin 1b51e571, and current main e6f1d77:
| Key | en-US | zh-Hans | ja-JP |
|---|---|---|---|
app.accessControlDialog.title |
Web App Access Control | Web 应用访问权限 | アクセス権限 |
workflow.blocks.knowledge-retrieval |
Knowledge Retrieval | 知识检索 | 知識検索 |
The old app.accessControl key no longer exists at any of the three refs. The dialog title is the right anchor: since 1.16.0 nothing labelled "Access Control" opens the dialog, and users reach it by clicking the current access level on the Web App card. The regenerated termbase matches derive-termbase.py output exactly. On main, --check fails because #1021 added the agentic workflow row without regenerating.
Suggestions are inline. Two notes outside the diff:
- Variable Assigner has the same kind of conflict. The concept row (line 73) has 变量赋值器 / 変数代入器, which are the values of
workflow.blocks.variable-assigner(en-US "Variable Aggregator"). The UI row (line 337,workflow.blocks.assigner) has 变量赋值 / 変数代入. Fine to fix here or leave for DC-284. - DC-284 already lists this Web App Access Control change, so this PR delivers part of it. Worth linking it in the description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The glossary contained conflicting node translations and an obsolete Web App Access Control key. This PR aligns those entries with the labels rendered by the product and regenerates the translation termbase.
知識検索. Scope the row to the node; generic retrieval prose retains descriptive wording.workflow.blocks.assigner:变量赋值/変数代入.app.accessControlDialog.titlefor Web App Access Control, move it beside the access-level entries, and explain that it is a dialog title for bold UI references. Users open it through the current access level on the Web App card. The Japanese value is also used bypermission.accessRule.accessPermission, so it must not become a blanket replacement for descriptive prose.chunkeras 分段器 / チャンカー, as requested in the update name #196 review; add General Chunker and Parent-child Chunker using the official plugin labels and Japanese English fallback; anchor Inverted Index to the Knowledge Base node'sdataset.retrieval.keyword_search.title(逆インデックス). General chunking prose continues to follow the existing glossary terms.agentic workflowrow is also restored from the already-approved glossary entry.This addresses Riskey's review. It delivers part of DC-310 and DC-284, without closing either issue. Only
writing-guides/glossary.mdandtools/translate/termbase_i18n.mdchange. Product code, CE role terminology, and the deferred CE 1.17.1 Skills content are outside this PR. These are shared authoring resources, so no release-content backport is requested.Verification
be8744264f9a6028ec5847dc5209b14ac9eb35caand EE rc30 pin1b51e5719c3965fc2c3c589c10454d5d80ddd0b7: the four core labels match the same keys in English, Chinese, and Japanese. Checked their render sites inapp-access-control/access-control-form.tsx, the Web App card, workflow block-selector/node metadata, and the Knowledge Base node's retrieval-setting hooks.60fd178450bf76fa651f348113a9bc93783dd1ee:tools/general_chunk/tools/general.yamlandtools/parent_child_chunk/tools/parent_child_chunk.yamlare unchanged from the previously verified3b4e77c0pin. Checkedidentity.label, the tool node's use oftool.label[language], andI18nObject._populate_missing_localesfor the Japanese fallback.python3 tools/translate/derive-termbase.py --checkandgit diff --checkpass. The generated diff contains only the corresponding glossary rows and the pre-existing missingagentic workflowrow.web/i18n/localesdirectory reports 64, down from 65. The remaining key cleanup stays in DC-284/DC-273; this is not a claim that the entire glossary audit passes.