Skip to content

fix: align glossary entries with rendered ui labels - #1065

Merged
Ill-donut merged 3 commits into
mainfrom
codex/ui-label-glossary-alignment
Sep 29, 2026
Merged

Ill-donut merged 3 commits into
mainfrom
codex/ui-label-glossary-alignment

Conversation

@Ill-donut

@Ill-donut Ill-donut commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

The glossary contained conflicting node translations and an obsolete Web App Access Control key. This PR aligns those entries with the labels rendered by the product and regenerates the translation termbase.

  • Keep Knowledge Retrieval in the Nodes table, with its description and the Japanese node name 知識検索. Scope the row to the node; generic retrieval prose retains descriptive wording.
  • Align Variable Assigner's concept row with workflow.blocks.assigner: 变量赋值 / 変数代入.
  • Use app.accessControlDialog.title for Web App Access Control, move it beside the access-level entries, and explain that it is a dialog title for bold UI references. Users open it through the current access level on the Web App card. The Japanese value is also used by permission.accessRule.accessPermission, so it must not become a blanket replacement for descriptive prose.
  • Complete the shared-glossary follow-ups from langgenius/Dify-Enterprise-Docs#196 and langgenius/Dify-Enterprise-Docs#197: define the generic noun chunker as 分段器 / チャンカー, as requested in the update name #196 review; add General Chunker and Parent-child Chunker using the official plugin labels and Japanese English fallback; anchor Inverted Index to the Knowledge Base node's dataset.retrieval.keyword_search.title (逆インデックス). General chunking prose continues to follow the existing glossary terms.
  • Regenerate the termbase. Its existing missing agentic workflow row is also restored from the already-approved glossary entry.

This addresses Riskey's review. It delivers part of DC-310 and DC-284, without closing either issue. Only writing-guides/glossary.md and tools/translate/termbase_i18n.md change. Product code, CE role terminology, and the deferred CE 1.17.1 Skills content are outside this PR. These are shared authoring resources, so no release-content backport is requested.

Verification

  • Dify main be8744264f9a6028ec5847dc5209b14ac9eb35ca and EE rc30 pin 1b51e5719c3965fc2c3c589c10454d5d80ddd0b7: the four core labels match the same keys in English, Chinese, and Japanese. Checked their render sites in app-access-control/access-control-form.tsx, the Web App card, workflow block-selector/node metadata, and the Knowledge Base node's retrieval-setting hooks.
  • Official plugins 60fd178450bf76fa651f348113a9bc93783dd1ee: tools/general_chunk/tools/general.yaml and tools/parent_child_chunk/tools/parent_child_chunk.yaml are unchanged from the previously verified 3b4e77c0 pin. Checked identity.label, the tool node's use of tool.label[language], and I18nObject._populate_missing_locales for the Japanese fallback.
  • python3 tools/translate/derive-termbase.py --check and git diff --check pass. The generated diff contains only the corresponding glossary rows and the pre-existing missing agentic workflow row.
  • No new unresolved glossary keys. At the EE pin, the key checker reports 19 existing unresolved entries, down from 20 on docs main. A read-only check adjusted for current Dify's web/i18n/locales directory reports 64, down from 65. The remaining key cleanup stays in DC-284/DC-273; this is not a claim that the entire glossary audit passes.

@Ill-donut
Ill-donut requested a review from RiskeyL as a code owner September 28, 2026 07:43
@mintlify

mintlify Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
dify-ce-cloud-docs 🟢 Ready View Preview Sep 28, 2026, 7:44 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@RiskeyL RiskeyL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified both rows at dify 0c5f2507, the EE rc30 pin 1b51e571, and current main e6f1d77:

Key en-US zh-Hans ja-JP
app.accessControlDialog.title Web App Access Control Web 应用访问权限 アクセス権限
workflow.blocks.knowledge-retrieval Knowledge Retrieval 知识检索 知識検索

The old app.accessControl key no longer exists at any of the three refs. The dialog title is the right anchor: since 1.16.0 nothing labelled "Access Control" opens the dialog, and users reach it by clicking the current access level on the Web App card. The regenerated termbase matches derive-termbase.py output exactly. On main, --check fails because #1021 added the agentic workflow row without regenerating.

Suggestions are inline. Two notes outside the diff:

  • Variable Assigner has the same kind of conflict. The concept row (line 73) has 变量赋值器 / 変数代入器, which are the values of workflow.blocks.variable-assigner (en-US "Variable Aggregator"). The UI row (line 337, workflow.blocks.assigner) has 变量赋值 / 変数代入. Fine to fix here or leave for DC-284.
  • DC-284 already lists this Web App Access Control change, so this PR delivers part of it. Worth linking it in the description.

Comment thread writing-guides/glossary.md
Comment thread writing-guides/glossary.md Outdated
@Ill-donut
Ill-donut merged commit 01f1cb6 into main Sep 29, 2026
1 check passed
@Ill-donut
Ill-donut deleted the codex/ui-label-glossary-alignment branch September 29, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants