xs mod to pricing page#3012
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude review |
There was a problem hiding this comment.
All three concerns from my prior review are addressed: pricing table, calculator (PLAN_CONFIGS + custom-pricing display), and md-override pricing.md heading + Example 5 are now consistently using "Custom" with a ,302 usage estimate (math checks out).
Extended reasoning...
Overview
This PR is the follow-up to my prior review on the Enterprise-price change. The original one-line edit ("499" → "Custom" in PricingTable.tsx:185) has been expanded to keep the three on-page surfaces consistent:
components/home/pricing/PricingTable.tsx— price label changed to"Custom".components/home/pricing/PricingCalculator.tsx—PLAN_CONFIGSnow models Enterprise as{ baseFee: null, priceLabel: "Custom" }; the component now stores the fullPlanConfigin state (currentPlanConfig) instead of tracking justcurrentBaseFee; the dropdown label uses the newpriceLabelfield; and the result card switches oncurrentBaseFee !== nullto render a "Custom pricing" panel with contact-sales copy plus a usage estimate at standard graduated rates. A smallgetPlanConfighelper centralizes lookups with a default fallback.md-override/pricing.md— heading is now### Enterprise (Custom)and Example 5 replaces the concrete $2,499/$8,801 numbers with "Enterprise pricing: Custom" + a $6,302.00/month usage estimate (72 + 630 + 2600 + 3000 = 6302 — math checks out) + a contact-sales note.
Security risks
None. This is a static pricing-copy/UI change in a docs site — no auth, crypto, network handling, or user input parsing is touched. The added getPlanConfig helper uses a hardcoded array lookup with a safe ?? DEFAULT_PLAN_CONFIG fallback for unknown plan names.
Level of scrutiny
Low. The repo is a Next.js marketing/docs site; the changes are concentrated in pricing display components and a markdown override that mirrors the live UI. The refactor is mechanical (a discriminated-union via baseFee: number | null) and the conditional render paths are visibly correct. auto-merge label is appropriate for this kind of change.
Other factors
- The inline comment from my previous review is marked
resolved=true, indicating the author treated it as actionable and addressed it. - The Hobby tier in
PricingTable.tsxalready uses"Free"(non-$ price) which the same rendering path handles, so the"Custom"value is well-precedented. - No CODEOWNER-owned code paths, no tests in scope to update, and the Vercel preview deployment is building.
Greptile Summary
This PR updates the Enterprise cloud tier price label from
"$2499"to"Custom"in the pricing table component.pricefield is typed asstring, so"Custom"is a valid value, and the existing rendering logic at line 1451 already handles non-$prices by suppressing the/ monthunit suffix — no display regressions expected."Custom Pricing"for a similar plan.Confidence Score: 5/5
Single-field text update; the rendering path already handles non-dollar price strings correctly, so the change is safe to merge.
Changing "$2499" to "Custom" on the Enterprise tier is a one-line copy update. The component's conditional logic (tier.price.includes("$")) already suppresses the / month suffix for non-dollar strings, and the self-hosted tier already uses "Custom Pricing" as a price, confirming this pattern is supported.
No files require special attention.
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[tier.price value] --> B{includes '$'?} B -- Yes --> C[Show price + '/ month' or '/ priceUnit'] B -- No --> D[Show price only, no unit suffix] D --> E["'Custom' renders as just 'Custom'"]Reviews (1): Last reviewed commit: "xs mod to pricing page" | Re-trigger Greptile