fix: add production-compatible RSS feed for changelog#2998
Open
GANESH-NADKARNI wants to merge 4 commits into
Open
fix: add production-compatible RSS feed for changelog#2998GANESH-NADKARNI wants to merge 4 commits into
GANESH-NADKARNI wants to merge 4 commits into
Conversation
Uses getChangelogIndexItems() with build-time data instead of fs.readdirSync, so the feed works on Vercel production. Fixes langfuse#1614
- Adds /api/changelog-rss.xml endpoint using getChangelogIndexItems() instead of fs.readdirSync so it works on Vercel production - Adds RSS Feed link to changelog page UI Fixes langfuse#1614
|
@GANESH-NADKARNI is attempting to deploy a commit to the langfuse Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: GANESH NADKARNI <ganeshnadkarni369@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a working RSS feed at
/api/changelog-rss.xmland anRSS button on the changelog page.
Why?
PR #1688 was reverted because it used Pages Router style
(
pages/api/changelog-rss.xml.ts) but the project has sincemigrated to App Router. This fix uses App Router convention
(
app/api/changelog-rss.xml/route.ts) withgetChangelogIndexItems()for build-time data loading — no filesystem access at runtime.
How to test?
pnpm devFixes #1614
Note: First-time contributor, happy to adjust based on feedback!
Greptile Summary
This PR adds a working RSS feed endpoint at
/api/changelog-rss.xmlusing the App Router convention and wires up an RSS button on the changelog page, replacing the previously reverted Pages Router implementation.app/api/changelog-rss.xml/route.ts— generates a valid RSS 2.0 feed fromgetChangelogIndexItems()at request time; item links and the Atom self-reference URL are hardcoded tohttps://langfuse.com, which will produce live-site URLs when running locally or on staging.app/changelog/page.tsx— adds an outlined RSS button in the page header; the button label isOpenRSS(single word) which appears to be a typo for "RSS Feed".Confidence Score: 4/5
Safe to merge; the feed works correctly in production, and the two issues (hardcoded base URL, button label typo) only affect developer experience and UI copy.
The route correctly builds and returns valid RSS XML using build-time data with no runtime filesystem access. The hardcoded
https://langfuse.comin item links and the atom:link self-reference is harmless in production but will mislead when testing locally or on staging. The button label 'OpenRSS' is a cosmetic typo visible to all changelog visitors.app/api/changelog-rss.xml/route.ts — hardcoded base URL on lines 14 and 32; app/changelog/page.tsx — button label typo on line 81.
Sequence Diagram
sequenceDiagram participant Client as RSS Reader / Browser participant Route as GET /api/changelog-rss.xml participant Lib as getChangelogIndexItems() participant Source as changelogSource (build-time data) Client->>Route: GET /api/changelog-rss.xml Route->>Lib: getChangelogIndexItems() Lib->>Source: changelogSource.getPages() Source-->>Lib: raw page list Lib-->>Route: sorted ChangelogPageItem[] Route->>Route: map items to RSS XML strings Route->>Route: compose full RSS 2.0 document Route-->>Client: "200 application/xml (Cache-Control: max-age=3600)"Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "fix: add RSS button to changelog page UI" | Re-trigger Greptile