Rust 2021, clippy clean, rustfmt etc.#9
Open
virtualritz wants to merge 1 commit intolancelet:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_sortedcrate. When using theunstablefeature theis_sortedcrate falls back to using the unstableis_sortedfeature. I.e. the crate will then only compile withnightly.Cargo.lockfrom git and movedsrc/main.rstoexamples/diagram.rs.TODO:
nalgebra::VectorNfor one of the alternatives.no_stdI removed the crate's
stddepedency as much as possible using resp. traits fromcoreinstead (and usingthiserror-no-std).To make this crate truly
no_std(i.e. particualrly not require allocations) consider abandoning the OOP approach where aCurveis astruct.Instead go for one where there are only the functions like
de_boor()etc. that take all the required curve data as slices instead ofVec.Curve::new()would be renamed tois_curve_ok().See e.g. my
uniform-cubic-splinescrate (which isno_std) for this approach.