fix(arrow-scalar): bound the lengths read while decoding a scalar - #8969
Open
jackylee-ch wants to merge 1 commit into
Open
fix(arrow-scalar): bound the lengths read while decoding a scalar#8969jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
Three values in the encoding come from varints and reach u64::MAX, and none of them were checked against the bytes present. The two length fields computed `offset + len`, which wraps and so slips past the very comparison meant to bound it, leaving the following slice out of range; the buffer count was reserved for before anything validated it. Resolve each run's end through a checked add, and reject a buffer count larger than the remaining bytes before allocating for it.
Contributor
There was a problem hiding this comment.
The checked endpoints and pre-allocation count bound correctly turn the three reported extreme length/count fields into errors without changing valid encodings.
A pre-existing malformed-type path remains: the self-described null type w:-1 still reaches Arrow’s infallible null allocator and panics. This PR neither introduces nor widens that path, so no change is requested here; follow-up hardening should validate parsed data types before null construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three lengths in the scalar encoding come from varints and can reach
u64::MAX, and none were checked against the bytes present.ArrowScalar::decodepanics on all three:The two length fields computed
offset + len, which wraps and so slips past the very comparison meant to bound it. The buffer count was reserved for before anything validated it.Resolve each run's end through a checked add, and reject a count larger than the remaining bytes.