feat(java): expose aggregate index fragment coverage - #8961
Open
everySympathy wants to merge 3 commits into
Open
feat(java): expose aggregate index fragment coverage#8961everySympathy wants to merge 3 commits into
everySympathy wants to merge 3 commits into
Conversation
| } else { | ||
| JObject::null() | ||
| }; | ||
| let fragment_coverage = if let Some(coverage) = description.fragment_coverage() { |
Collaborator
There was a problem hiding this comment.
Do we need to exclude system indexes
Contributor
Author
There was a problem hiding this comment.
Good point. System indexes should remain visible in describeIndices for compatibility, but their bitmaps do not represent normal data-index coverage (__lance_frag_reuse tracks remapping participation, while __mem_wal may have no bitmap). Fixed in e6c513d at the Rust core layer: all system indexes now return no fragment coverage, so JNI exposes Optional.empty(). Added regression coverage for both bitmap-bearing frag reuse and bitmap-less mem-wal indexes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Java callers can inspect each segment fragment list today, but must materialize every fragment id in the JVM to calculate logical index coverage. This is expensive for large datasets and does not expose the serialized bitmap size.
What
Tests