Skip to content

fix(python): complete some straightforward API annotations - #8954

Open
jonasdedden wants to merge 1 commit into
lance-format:mainfrom
jonasdedden:fix/python-trivial-type-annotations
Open

fix(python): complete some straightforward API annotations#8954
jonasdedden wants to merge 1 commit into
lance-format:mainfrom
jonasdedden:fix/python-trivial-type-annotations

Conversation

@jonasdedden

Copy link
Copy Markdown
Contributor

Summary

  • correct Dict[str, any] to Dict[str, Any]
  • parameterize public dictionaries and AbstractContextManager
  • use the directly imported Arrow Expression type instead of an unresolved module attribute
  • annotate variadic keyword arguments and the None return from create_scalar_index

@github-actions github-actions Bot added A-python Python bindings bug Something isn't working labels Sep 2, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: approve.

These corrections remove the demonstrated invalid and unresolved public annotation types while keeping the runtime API and import behavior unchanged. Keeping the annotations inline also avoids a second type-definition surface.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-python Python bindings bug Something isn't working K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant