fix(python): complete some straightforward API annotations - #8954
Open
jonasdedden wants to merge 1 commit into
Open
fix(python): complete some straightforward API annotations#8954jonasdedden wants to merge 1 commit into
jonasdedden wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
These corrections remove the demonstrated invalid and unresolved public annotation types while keeping the runtime API and import behavior unchanged. Keeping the annotations inline also avoids a second type-definition surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dict[str, any]toDict[str, Any]AbstractContextManagerExpressiontype instead of an unresolved module attributeNonereturn fromcreate_scalar_index