fix: collect unreferenced data newer than retained manifests - #8944
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
fix: collect unreferenced data newer than retained manifests#8944lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The data listing now covers the union of manifest-proven stale files and files past the moving unverified threshold, while retained-manifest references and the existing recent-write guard continue to protect live data. This addresses the leak at the candidate-visibility boundary without changing the cleanup API or format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
cleanup_old_versions capped the data subtree listing at the earliest retained manifest timestamp. Abandoned writes are not owned by any manifest and can be newer than that timestamp, so they never reached the existing age and delete_unverified checks.
Validation
Fixes #8942