Skip to content

feat(fts): define global BM25 statistics wire contract - #8938

Open
zhangstar333 wants to merge 2 commits into
lance-format:mainfrom
zhangstar333:fts_proto
Open

feat(fts): define global BM25 statistics wire contract#8938
zhangstar333 wants to merge 2 commits into
lance-format:mainfrom
zhangstar333:fts_proto

Conversation

@zhangstar333

Copy link
Copy Markdown

Distributed FTS executors need one query-bound, corpus-wide BM25 statistics payload so workers searching different index segments can produce comparable scores.

This is part of #8937 and supports the downstream Doris use case described in apache/doris#67435.

@github-actions github-actions Bot added the enhancement New feature or request label Sep 2, 2026
lance-gatekeeper[bot]

This comment was marked as outdated.

@lance-gatekeeper lance-gatekeeper Bot added the K-changes Latest Gatekeeper recommendation requests changes. label Sep 2, 2026
@lance-gatekeeper lance-gatekeeper Bot removed the K-changes Latest Gatekeeper recommendation requests changes. label Sep 2, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: approve.

The current revision addresses both prior findings: V1 now fails closed for cross-corpus leaves and explicitly assigns same-query attachment to the trusted planner. The single-corpus wire scope matches #8937, and the schema/build integration compiles cleanly.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Sep 2, 2026
@zhangstar333

zhangstar333 commented Sep 2, 2026

Copy link
Copy Markdown
Author

@Xuanwo hi, could you please have a look at this pr when you are free, very Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant