test(io): stop test_cloud_paths from resolving S3 region over network#7808
Open
wjones127 wants to merge 1 commit into
Open
test(io): stop test_cloud_paths from resolving S3 region over network#7808wjones127 wants to merge 1 commit into
wjones127 wants to merge 1 commit into
Conversation
`test_cloud_paths` and the S3 case of `test_block_size_used_cloud` opened `s3://bucket/foo.lance` with no region configured. `resolve_s3_region` then makes a live HEAD request to `bucket.s3.amazonaws.com` to read the `x-amz-bucket-region` header. That request is flaky in CI: when the header is absent the call fails with `RegionParse`, panicking the test — while other tests hitting the same path in the same run pass, confirming non-determinism. These tests only verify URL/path parsing, so pass a static `region` storage option, which short-circuits `resolve_s3_region` before any network call. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughS3-related tests now pass static ChangesS3 test configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
wjones127
marked this pull request as ready for review
July 15, 2026 19:24
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
object_store::tests::test_cloud_pathsis failing onmainin the Rust CI job.The test opens
s3://bucket/foo.lancewith no region configured.resolve_s3_regionthen makes a live HEAD request tobucket.s3.amazonaws.comto read thex-amz-bucket-regionheader. That request is flaky in CI: when the header is absent the call fails withRegionParse { bucket: "bucket" }, panicking the.unwrap(). In the same failing run,test_block_size_used_cloud::case_1— which hits the identical code path — passed, confirming the failure is non-deterministic network behavior, not a logic regression.The affected tests only verify URL/path parsing, so they have no reason to reach the network. This passes a static
regionstorage option for the S3 cases, which short-circuitsresolve_s3_regionbefore any request is made.test_block_size_used_cloud's S3 case shares the same flaw and is fixed the same way.🤖 Generated with Claude Code
Summary by CodeRabbit