fix(build): add Android aarch64 support to lance-linalg#6057
Merged
Xuanwo merged 2 commits intolance-format:mainfrom Mar 2, 2026
Merged
fix(build): add Android aarch64 support to lance-linalg#6057Xuanwo merged 2 commits intolance-format:mainfrom
Xuanwo merged 2 commits intolance-format:mainfrom
Conversation
The Android aarch64 build fails because lance-linalg v2.0.0's build script doesn't recognize target_os == "android" as a valid target for aarch64, causing it to error even though the fp16kernels feature isn't enabled
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
dardourimohamed
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Mar 4, 2026
…#6057) ## Summary - Add `target_os == "android"` condition for aarch64 builds in lance-linalg ## Problem The Android aarch64 build fails because lance-linalg v2.0.0's build script doesn't recognize `target_os == "android"` as a valid target for aarch64, causing it to error even when the `fp16kernels` feature isn't enabled. ## Solution Extended the aarch64 build condition to include Android alongside Linux, since both support the same NEON instruction set. Fixes build failures on Android targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_os == "android"condition for aarch64 builds in lance-linalgProblem
The Android aarch64 build fails because lance-linalg v2.0.0's build script doesn't recognize
target_os == "android"as a valid target for aarch64, causing it to error even when thefp16kernelsfeature isn't enabled.Solution
Extended the aarch64 build condition to include Android alongside Linux, since both support the same NEON instruction set.
Fixes build failures on Android targets.