fix: allowing headers for static configuration to be consistent#6045
Open
hamersaw wants to merge 1 commit intolance-format:mainfrom
Open
fix: allowing headers for static configuration to be consistent#6045hamersaw wants to merge 1 commit intolance-format:mainfrom
hamersaw wants to merge 1 commit intolance-format:mainfrom
Conversation
Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
hamersaw
changed the title
Xuanwo
approved these changes
Feb 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now configuration names for injecting custom headers at different points is not consistent. For example, REST namespace uses
header.*for static configuration, butheaders.*for dynamic configuration. In addition, the object store custom headers useheaders.*and all of our docs useheaders.*. Therefore, this PR adds support forheaders.*in static configuration, but leavesheader.*for backwards compatibility.