Merged
Conversation
Contributor
Author
jarkabaker
approved these changes
Mar 4, 2025
Member
peterbjohnson
left a comment
peterbjohnson
left a comment
There was a problem hiding this comment.
Minor comments on naming
| fileName: z.string(), | ||
| typeOfFile: TypeOfFileSchema, | ||
| markdown: z.string(), | ||
| isMilkdown: z.boolean().optional(), |
Member
There was a problem hiding this comment.
Would it be better to generalise this to e.g. implicitFigures: z.boolean().optional(),?
Milkdown isn't fundamental here.
| ) => { | ||
| // pandoc source format | ||
| // If Milkdown, disable the implicit_figures extension to remove all image captions | ||
| const fromString = isMilkdown ? "markdown-implicit_figures" : "markdown+implicit_figures"; |
Member
There was a problem hiding this comment.
Suggest don't put the type in the name, because it is already typed. Make a more general name for this variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/Y00aQcrl
Changes
This PR adds an
isMilkdownprop to the lambda's schema and uses this to determine whether to produce a PDF withimplicit_figuresenabled or not. It also sets figures to be centered and in place using thefloatLaTeX package.This should be merged alongside the other PR: https://github.com/lambda-feedback/client-backend/pull/252