Conversation
peterbjohnson
left a comment
There was a problem hiding this comment.
Looks good, and good that there are tests.
We can test on STAGING too before PROD.
Consider requesting a migration in the DB so that legacy content benefits from this change (ask Jarka).
Note that symbolicEqual is an independent function that we need to retire, and that would avoid any discussion of whether we apply maintenance to that function too. Ask me for details. Karl 'finished' work on that but I don't know where we are with completing the obsolescence.
|
Thanks! Currently, we can't test on staging before going to production. Unless I implement my workflow change, which I was going to discuss with you next week. I'm happy to beta test it here. I'll request a migration, it looks like there are ~32,000 response areas with rtol or atol in |
|
Ah ok. The fix here isn't urgent. So if STAGING is nearly ready, you could wait and use this as the test case? |
Enabled support for absolute_tolerance and relative_tolerance with backward compatibility of atol and rtol.
After merging to main and deployment, Lambda Feedback UI can be updated to use relative_tolerance and absolute_tolerance by default instead of rtol and atol.