Skip to content

Fix GUI freeze on stop and prevent corrupted XDF footers #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sappelhoff wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Fix GUI freeze on stop and prevent corrupted XDF footers #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e44806d
fix: make thread shutdown interruptible and abort sockets on teardown
sappelhoff Aug 27, 2026
c5d3038
test: add automated integration test for instant shutdown and XDF val…
sappelhoff Aug 27, 2026
10d3507
Merge remote-tracking branch 'origin/master' into fix/instant-shutdow…
sappelhoff Sep 20, 2026
54ffd28
Bound every wait in recording teardown and stop dropping buffered sam…
sappelhoff Sep 20, 2026
c812292
Keep recording state alive for threads that outlive teardown, and dra…
sappelhoff Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 23 additions & 13 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ jobs:
fail-fast: false
matrix:
config:
- { name: "Ubuntu 22.04", os: ubuntu-22.04 }
- { name: "Ubuntu 24.04", os: ubuntu-24.04 }
- { name: "macOS", os: macos-14, cmake_extra: '-DCMAKE_OSX_ARCHITECTURES="x86_64;arm64"' }
- { name: "Windows", os: windows-latest }
- { name: "Ubuntu 22.04", os: ubuntu-22.04, cli: "install/bin/LabRecorderCLI" }
- { name: "Ubuntu 24.04", os: ubuntu-24.04, cli: "install/bin/LabRecorderCLI" }
- { name: "macOS", os: macos-14, cmake_extra: '-DCMAKE_OSX_ARCHITECTURES="x86_64;arm64"', cli: "install/LabRecorderCLI" }
- { name: "Windows", os: windows-latest, cli: "install/LabRecorderCLI.exe" }

steps:
- name: Checkout
Expand Down Expand Up @@ -97,17 +97,27 @@ jobs:
# -----------------------------------------------------------------------
# Test CLI
# -----------------------------------------------------------------------
- name: Test CLI (Linux)
if: runner.os == 'Linux'
run: ./install/bin/LabRecorderCLI --help || true
- name: Test CLI
shell: bash
run: ./${{ matrix.config.cli }} --help || true

# -----------------------------------------------------------------------
# Integration test: teardown latency and XDF integrity
# -----------------------------------------------------------------------
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.12'

- name: Test CLI (macOS)
if: runner.os == 'macOS'
run: ./install/LabRecorderCLI --help || true
- name: Install integration test dependencies
run: python -m pip install --upgrade pip pylsl pyxdf

- name: Test CLI (Windows)
if: runner.os == 'Windows'
run: ./install/LabRecorderCLI.exe --help || true
# pylsl brings its own liblsl; it only has to speak the same wire protocol as the liblsl
# bundled with the recorder, not be the same build. Set PYLSL_LIB here if that ever stops
# holding.
- name: Test recording teardown
shell: bash
run: python scripts/test_recording_teardown.py --bin "${{ matrix.config.cli }}"

# -----------------------------------------------------------------------
# Package
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ liblsl.deb
install-qt.sh
.DS_Store
.codegraph/
__pycache__/
Loading
Loading