Repository navigation
test(query): leave the abandoned-run test only after its run starts - #505
Merged
Merged
Conversation
The test cancelled its caller once the flight registered, before the run marked its read slot. A run still queued when its last caller leaves is cancelled by design, so the next lookup missed. Wait for the run to start, as the coalescing test does.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestResultCacheAbandonedRunsCompleteAndAreReusedcancelled its caller as soon as the in-flight run was registered, before the run marked that it held a read slot. A run that is still queued when its last caller leaves is cancelled by design, so nothing was cached and the next lookup missed (v=0 outcome=miss err=ran again). This failure took #504 out of the merge queue once. The test now waits for the run to start, as the coalescing test does. It fails under 300 repeated runs without the fix and passes with it.