Skip to content

test(query): leave the abandoned-run test only after its run starts - #505

Merged
vishr merged 2 commits into
mainfrom
fix/result-cache-abandoned-test-race
Nov 19, 2026
Merged

vishr merged 2 commits into
mainfrom
fix/result-cache-abandoned-test-race

Conversation

@vishr

@vishr vishr commented Nov 18, 2026

Copy link
Copy Markdown
Member

TestResultCacheAbandonedRunsCompleteAndAreReused cancelled its caller as soon as the in-flight run was registered, before the run marked that it held a read slot. A run that is still queued when its last caller leaves is cancelled by design, so nothing was cached and the next lookup missed (v=0 outcome=miss err=ran again). This failure took #504 out of the merge queue once. The test now waits for the run to start, as the coalescing test does. It fails under 300 repeated runs without the fix and passes with it.

The test cancelled its caller once the flight registered, before the run
marked its read slot. A run still queued when its last caller leaves is
cancelled by design, so the next lookup missed. Wait for the run to start,
as the coalescing test does.
@vishr
vishr added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@vishr
vishr added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit c7b3ff3 Nov 19, 2026
29 checks passed
@vishr
vishr deleted the fix/result-cache-abandoned-test-race branch November 19, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant