Fix websocket cookbook examples busy-looping after client disconnect - #443
Open
wakqasahmed wants to merge 1 commit into
Open
wakqasahmed wants to merge 1 commit into
wakqasahmed wants to merge 1 commit into
Conversation
wakqasahmed
force-pushed
the
fix/cookbook-websocket-busy-loop
branch
from
September 13, 2026 07:31
34ffaec to
6ca5971
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both websocket cookbook examples (`cookbook/websocket/gorilla` and `cookbook/websocket/net`) run their write/read loop unconditionally — on a write or read error they log it and loop right back around instead of exiting. Once a client disconnects, every subsequent `WriteMessage`/`ReadMessage` call errors immediately, so the handler spins as fast as possible logging errors forever instead of returning.
Added an early return on both the write-error and read-error paths in each example, so the handler exits (and `defer ws.Close()` runs) as soon as the connection is gone, matching how these examples are meant to demonstrate correct websocket handling.
Added a test per example that connects a client, closes it immediately, and asserts the handler goroutine actually returns within a couple seconds — this fails against the old code (the handler never returns, so the test would time out) and passes with the fix.