Repository navigation
fix: prevent nil pointer panic and close response body in RunPushGateway - #4
Open
azatmuhammetamanov01 wants to merge 1 commit into
Open
azatmuhammetamanov01 wants to merge 1 commit into
azatmuhammetamanov01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
RunPushGatewayGatherer, whenclient.Do(req)returns an error (e.g. thepush gateway is unreachable), the error handler is called but execution
continues to
res.StatusCode. Sinceresis nil in that case, this causes anil pointer dereference panic.
Because the default
ErrorHandlerreturnsnil, any network error with thedefault config crashes the application.
Additionally,
res.Bodywas never closed, leaking connections.Fix
continueafter handling theclient.Doerror.res.Bodyafter a successful request.Tests
Added
TestRunPushGatewayGatherer_UnreachableGateway, which points thegatherer at a closed server. Before the fix it panics with a nil pointer
dereference; after the fix it passes.
go test -race ./...andgo vet ./...are clean.