fix: preserve Qwen3.5 MoE switch projection names#653
Open
ukint-vs wants to merge 2 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gate_proj,up_proj, anddown_projweights under theswitch_mlp.*_projnames read bySwitchGLU::from_weightsswitch_mlp.gate_proj/up_proj/down_projtow1/w3/w2Root cause
Some Qwen3.5 MoE checkpoints store expert weights as
model.layers.N.mlp.experts.E.{gate_proj,up_proj,down_proj}. The sanitizer stacked those tensors but wrote them asswitch_mlp.w1/w3/w2, while the loader later expectsswitch_mlp.gate_proj/up_proj/down_proj. That caused model loading to fail with missingswitch_mlp.gate_projweights.Validation
cargo test qwen3_5_tests::sanitize --features metal,accelerate -- --ignored --test-threads=1mlx-community/Ornith-1.0-35B-4bitafter the loader fix