Repository navigation
ci: use release app token for changesets - #13
Merged
Merged
Conversation
|
Contributor
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
changesets/actionopens the "Release new version" PR and pushes thechangeset-release/mainbranch with the defaultGITHUB_TOKEN. GitHub does not trigger workflows for events created byGITHUB_TOKEN, so runs on that PR sit ataction_required(e.g. #12, labd/intl-extractor#26) and the required org Security Checks never complete, which blocks the merge.Fix
lab-digital-release-bot(actions/create-github-app-token, SHA-pinned v3.3.0) usingvars.RELEASE_APP_ID/secrets.RELEASE_APP_PRIVATE_KEY, scoped tocontents: writeandpull-requests: write.changesets/actionviagithub-token. The action uses that token for the API calls, for the release branch / tag pushes (withpush-with-git-cliit injects it as a command-scopedhttp.extraHeader, so checkout credentials are not needed), and exports it asGITHUB_TOKENto the version/publish scripts.GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}env on the changesets step where present: v2 errors out when that env differs fromgithub-token.npm trusted publishing (OIDC),
environment: release, checkout settings and caching are unchanged.