Support specify recipient window explicitly#18
Open
xiaoyao9184 wants to merge 1 commit intokylewelsby:masterfrom
Open
Support specify recipient window explicitly#18xiaoyao9184 wants to merge 1 commit intokylewelsby:masterfrom
xiaoyao9184 wants to merge 1 commit intokylewelsby:masterfrom
Conversation
Support post back to opener implicit Update karma to 4.0.0 Fix confusion bind message by use new window object for each test spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support specify sender or use window.opener if exist
And i can‘t run the unit test, so i update karma to 4.0.0
And i think multiple test spec shared use the same window, make bind message confusion,
So i change to create new window for each test spec.