lock feature gate VolumeAttributesClass #53811
Conversation
Signed-off-by: carlory <baofa.fan@daocloud.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
| fromVersion: "1.34" | ||
| - stage: stable | ||
| defaultValue: true | ||
| locked: true |
There was a problem hiding this comment.
The locked field is not used in the feature-gate-table.html file. Do we forget to add it or it is unsupported?
VolumeAttributesClass feature gate was marked as GA in 1.34, but the locked field was added in 1.36. How to handle this case?
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/cc @lmktfy |
lmktfy
left a comment
lmktfy
left a comment
There was a problem hiding this comment.
I don't know how the locked field is supposed to be used.
| toVersion: "1.33" | ||
| - stage: stable | ||
| defaultValue: true | ||
| fromVersion: "1.34" |
There was a problem hiding this comment.
if this is the right thing to do, it needs a toVersion
3 participants
Description
A follow-up of kubernetes/kubernetes#134556
https://github.com/kubernetes/kubernetes/blob/15673d04e30c711a7bb0f0efe6abf4baead1463b/pkg/features/kube_features.go#L1910-L1915
Issue
Closes: #