Skip to content

Conversation

@paulofponciano
Copy link
Contributor

Description

The current navbar-lang-selector behavior lists all languages in the dropdown even when no translations are available for the current page. When a user selects a language, they are redirected to that language's home page instead of a translated version of the current page.
This misleads users into thinking translations exist for the page, and they only discover it's a fallback behavior after being redirected to the home page.

Proposed changes in this PR:

  • Only display the dropdown when translations actually exist for the current page
  • Show just the language name (without dropdown) when no translations are available (EN default language)

Repo file: /layouts/partials/navbar-lang-selector.html

Example pages with current behavior (EN only at this time):

The same pages can be used to evaluate the new behavior in staging.

Issue

Closes: #53803

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 25, 2025
@netlify
Copy link

netlify bot commented Dec 25, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 343b4d8
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/694d27eb1728a90008ebbd6a
😎 Deploy Preview https://deploy-preview-53804--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed change to navbar-lang-selector behavior

2 participants