-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Add ResourceMetricsConfig for configurable core resource metrics #2742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Rishab87 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Just before you continue on this, it would be good to sync with @rexagod and myself as there's kubernetes/enhancements#4811 https://github.com/rexagod/resource-state-metrics out there as well :) |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What this PR does / why we need it:
Implements ResourceMetricsConfig to allow users to define custom metrics for core Kubernetes resources (Pods, Deployments, etc.) via YAML configuration. This enables users to create only the metrics they need, reducing cardinality and eliminating the complexity of allowlists/denylists. The feature reuses the proven CustomResourceState metric generation system for familiar configuration syntax.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Decreases cardinality by allowing users to define only specific metrics they need instead of all default metrics for a resource type.
Which issue(s) this PR fixes: (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)Fixes #2165