ci: add automatic git hooks installation

[meomnzak]

Description

Pre-commit hooks are now automatically installed when running make build or make test. This ensures all contributors run linting checks before commits without manual setup.

Also removes the go test ./... hook from pre-commit config since running the full test suite on every commit is too slow.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Helm chart change
• Other (please describe)

Testing

• Unit tests added/updated
• Helm chart tests pass (helm lint and template validation)
• Tested changes manually
• Added examples for new features

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have updated the relevant CRDs if needed
• I have updated the Helm chart version if needed
• I have added tests that prove my fix is effective or that my feature works

Additional context

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: meomnzak
Once this PR has been reviewed and has the lgtm label, please assign pfeifferj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.77%. Comparing base (1a630bd) to head (898eaf0).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   55.77%   55.77%           
=======================================
  Files          58       58           
  Lines        8757     8757           
=======================================
  Hits         4884     4884           
  Misses       3525     3525           
  Partials      348      348           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pfeifferj]

generally, you raise some good points. I have some questions/concerns regarding the implementation

[pfeifferj]

I think adding this now is fine, but generally I'd like to keep the readme as lean as possible.

cleaning up the readme/moving various bits of info to ./docs would be a nice followup ticket to create but I think it would be something I need to work on.

[pfeifferj]

I understand that the long runtime of tests is annoying but I don't want us to remove this entirely.

would moving them to a pre-push hook be a sensible compromise?

[pfeifferj]

I don't think this is an intuitive way to install the hooks and neither is the test target.

the ci target might make more sense.

[meomnzak]

Totally fair point that this is not the most Intuitive place, but this is actually the reason behind this pr haha.
I always forgot make lint, and I saw other contributors miss that too. And I was like, why not make a pre-commit, but I actually found we have one. So the point was to document that we have it somewhere. And to make the developers install it in a "sneaky" way, since we always make build and make test.
I’m open to adjusting where the auto-install happens if there’s a better onboarding target, as long as we keep the hooks easy to discover and hard to miss.

[pfeifferj]

I don't think there's a point in being "sneaky" about it when the people who would benefit from it would probably also never think of running any of the make commands. but that's just my $0.02

[meomnzak]

Yeah makes sense, appreciate you sharing your perspective

[pfeifferj]

isn't this redundant if we have the ensure-hooks target?