Skip to content

Conversation

@nekkunti
Copy link
Contributor

@nekkunti nekkunti commented Dec 22, 2025

Description

Add IBM disruption reasons

Type of change

New feature / enhancement ( closes issue#439)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nekkunti
Once this PR has been reviewed and has the lgtm label, please assign pfeifferj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 22, 2025
@nekkunti
Copy link
Contributor Author

@pfeifferj Could you review this .

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.79%. Comparing base (1a630bd) to head (2c5a6da).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   55.77%   55.79%   +0.02%     
==========================================
  Files          58       58              
  Lines        8757     8762       +5     
==========================================
+ Hits         4884     4889       +5     
  Misses       3525     3525              
  Partials      348      348              
Files with missing lines Coverage Δ
pkg/cloudprovider/cloudprovider.go 54.50% <100.00%> (+0.57%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2025
…drift

feat: add subnet drift detection
Signed-off-by: Anand Nekkunti <anand.nekkunti@ibm.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2025
@nekkunti
Copy link
Contributor Author

nekkunti commented Dec 23, 2025

@pfeifferj merge conflict resolved , could you check this

@pfeifferj
Copy link
Member

thank you @nekkunti I'll take a look either today or tomorrow

@pfeifferj pfeifferj added this to the v1.0.1 milestone Dec 23, 2025
@pfeifferj
Copy link
Member

pfeifferj commented Dec 23, 2025

there's a blocker upstream for this to be actually useful

kubernetes-sigs/karpenter#2741

that's on me for not checking how this is implemented in core. I based #439 off the AWS provider which has the method but it's never called

we can revisit this if upstream adds support for provider-defined disruption reasons

@nekkunti
Copy link
Contributor Author

there's a blocker upstream for this to be actually useful

kubernetes-sigs/karpenter#2741

that's on me for not checking how this is implemented in core. I based #439 off the AWS provider which has the method but it's never called

we can revisit this if upstream adds support for provider-defined disruption reasons

Thanks , Please let me know once the upstream work is done, I’ll be happy to continue from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants