oss(credentials): support STS.Token in nodePublishSecretRef and rotation by republish #1591
+3,597
−431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlbeeSo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
AlbeeSo
force-pushed
the
oss/token-rotation-rewrite
branch
2 times, most recently
from
77d2b5d to
da50d2e
Compare
AlbeeSo
force-pushed
the
oss/token-rotation-rewrite
branch
from
da50d2e to
5817fea
Compare
mowangdk
reviewed
Dec 24, 2025
pkg/mounter/utils/filelock.go
Outdated
| } | ||
|
|
||
| // WriteFileWithLock safely writes data to file with locking | ||
| func WriteFileWithLock(path string, data []byte, perm os.FileMode) (done bool, err error) { |
Contributor
There was a problem hiding this comment.
Does this lock secure the secret file update? If we write a new token to a separate file and then rename it, we wouldn't need locks?
AlbeeSo
force-pushed
the
oss/token-rotation-rewrite
branch
3 times, most recently
from
9465193 to
c3b1c21
Compare
iltyty
reviewed
Dec 25, 2025
AlbeeSo
force-pushed
the
oss/token-rotation-rewrite
branch
from
c3b1c21 to
4f91d33
Compare
AlbeeSo
force-pushed
the
oss/token-rotation-rewrite
branch
from
6021061 to
51b3bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
requiredRepublishto true.kubectl create -n default secret generic oss-secret --from-literal='accessKeyId=<yourAccessKeyFromAssumeRole>' --from-literal='accessKeySecret=<yourAccessKeySecretFromAssumeRole>' --from-literal='securityToken=<yourSecurityTokenFromAssumeRole>' --from-literal='Expiration=2025-12-22T04:11:50Z'Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: