disk: fix Detaching disks treated as attached #1520
+428
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrating batcher and throttle.
Sometimes we are actually slowing down the system with batching. Optimize logs to diagnose this.
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/XL
huww98
force-pushed
the
fix-detach-then-attach
branch
from
dd1ef56 to
1478c78
Compare
huww98
force-pushed
the
fix-detach-then-attach
branch
from
1478c78 to
0f325d8
Compare
We should reject to attach disk detaching from the requested node.
huww98
force-pushed
the
fix-detach-then-attach
branch
from
0f325d8 to
ea3e114
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We should reject to attach disk detaching from the requested node.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
It is strange that ECS does not return error on attaching a detaching disk. But we fix it at our side first.
/hold
based on #1460, wait for that one to be merged first
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: