-
Notifications
You must be signed in to change notification settings - Fork 252
disk: attach disks with serial number at controller #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
c1e5398 to
30d433a
Compare
|
/unhold |
30d433a to
25da495
Compare
25da495 to
a0e9edf
Compare
a0e9edf to
336bd7a
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
336bd7a to
72d6526
Compare
|
based on #1330 |
72d6526 to
8b269b9
Compare
5b05b41 to
f598525
Compare
f598525 to
fae2dff
Compare
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/remove-lifecycle rotten |
|
@huww98: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fae2dff to
38d82c3
Compare
Attach and detach must be migrated at once, because NodeUnstageVolume may be followed immediately by another NodeStageVolume, without controller actions. So if we detach disk at NodeUnstageVolume, NodeStageVolume will not find the disk. Note: user must upgrade controller before node, to avoid any missing detach. This is the first step to move all attach/detach back to controller, in order to: - reduce RAM permission on node - more effective request batching - rely less on node, which can be down - resolve some rare racing issue
38d82c3 to
08e258d
Compare
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Attach and detach must be migrated at once, because NodeUnstageVolume may be followed immediately by anoterh NodeStageVolume, without controller actions.
So if we detach disk at NodeUnstageVolume, NodeStageVolume will not find the disk.
Note: user must upgrade controller before node, to avoid any missing detach.
This is the first step to move all attach/detach back to controller, in order to:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/hold
merge after #1087
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: