Add SharedInformer implementation to python-client#2515
Add SharedInformer implementation to python-client#2515
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…example Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@copilot can you add support for BOOKMARK events? |
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Done in 9c708ad. Added a |
|
@copilot can you implement it so that the most recent resourceVersion is stored and used for the re-list operation? |
… on 410 Gone Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Done in d21aa1b. |
|
@copilot can you add end-to-end tests against a real cluster |
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Done in 63bd3d5. Added
Each test uses a unique name (UUID suffix) and registers |
|
@copilot tests are failing, please fix. |
…eral) Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Fixed in 4bf1e06. The CI failure was a flake8 |
|
@brendandburns are you experimenting or you really trying to get this working ... very interested in this 😄 |
|
@aojea I'm definitely really trying to get it working, but via copilot. |
well, that is a good kubecon talk 😄 we can always try to give him the last push 👍 |
|
@copilot e2e tests are timing out. Looks like the test that the resource version advances isn't working right. Please fix. |
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Fixed in 90c2b02. The root cause was a race: The fix syncs |
Fixed in 90c2b02. The root cause was that The fix: |
kubernetes/informer/cache.pywith thread-safeObjectCacheand_meta_namespace_keykubernetes/informer/informer.pywithSharedInformer;_resource_versionsynced from Watch before each handler fires_resource_version; synced before firing handlers; reset on 410 Gonekubernetes/informer/__init__.pyexporting public APIinformertokubernetes/__init__.pykubernetes/test/test_informer.py(includingtest_resource_version_updated_mid_stream)kubernetes/e2e_test/test_informer.pyexamples/informer_example.pyOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.