Skip to content

Remove Spring Bazel jobs from bazel.yml and keep PR branch current with master#4760

Merged
k8s-ci-robot merged 11 commits into
masterfrom
copilot/switch-to-bazel-for-cicd
May 20, 2026
Merged

Remove Spring Bazel jobs from bazel.yml and keep PR branch current with master#4760
k8s-ci-robot merged 11 commits into
masterfrom
copilot/switch-to-bazel-for-cicd

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 17, 2026

Spring module builds/tests were duplicated in bazel.yml even though Spring coverage already exists in spring.yml. This change removes the duplicate Spring Bazel jobs so CI ownership is clearer and non-overlapping.

  • Workflow scope cleanup (.github/workflows/bazel.yml)

    • Removed Spring-specific Bazel build step:
      • Build Spring modules (Java 17+)
    • Removed Spring-specific Bazel test step:
      • Test Spring modules (Java 17+)
    • Left core Bazel build/test matrix intact.
  • Branch currency

    • Merged latest origin/master into the PR branch to keep it current with upstream changes.
# Removed from bazel.yml
- name: Build Spring modules (Java 17+)
  run: |
    bazel build --config=ci \
      //spring:client-java-spring-integration \
      //spring-aot:client-java-spring-aot-integration

- name: Test Spring modules (Java 17+)
  run: |
    bazel test --config=ci \
      //spring:tests

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2026
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2026
Copilot AI changed the title Switch CI/CD to Bazel exclusively, align matrix with previous Maven build Remove duplicate spring builds from bazel.yml May 17, 2026
Copilot AI changed the title Remove duplicate spring builds from bazel.yml Remove Spring Bazel jobs from bazel.yml and keep PR branch current with master May 17, 2026
@brendandburns brendandburns marked this pull request as ready for review May 17, 2026 18:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2026
@brendandburns
Copy link
Copy Markdown
Contributor

@copilot please fix windows builds, look like there may be a path problem?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 18, 2026

@copilot please fix windows builds, look like there may be a path problem?

Fixed in b2b9d50. I changed the Bazel build/test steps in .github/workflows/bazel.yml to use folded YAML commands (no shell line-continuation backslashes), which avoids the Windows bash parsing issue that turned //... labels into invalid /... labels.

@brendandburns
Copy link
Copy Markdown
Contributor

@copilot windows build is still failing. CodeQL is also, please fix.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 20, 2026

@copilot windows build is still failing. CodeQL is also, please fix.

Fixed in c6c8e92.

  • Windows Bazel builds: set MSYS2_ARG_CONV_EXCL: "*" in .github/workflows/bazel.yml so //pkg:target labels are not rewritten on Windows bash runners.
  • CodeQL: switched .github/workflows/codeql-analysis.yml to build-mode: none and removed the now-unneeded Bazel build/cache setup steps that were causing the Java extraction configuration failure.

Copy link
Copy Markdown
Contributor

@brendandburns brendandburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Copilot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@k8s-ci-robot k8s-ci-robot merged commit 7cca6c8 into master May 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants