Conversation
There was a problem hiding this comment.
Pull request overview
Updates the MySQL version used across ProxySQL and MySQL documentation examples, moving the sample manifests from 5.7.44 to 9.1.0 so the guides reflect a newer default MySQLVersion in KubeDB.
Changes:
- Updated
spec.versionin multiple inline YAML snippets inside ProxySQL and MySQL guides. - Updated referenced example YAML manifests under the corresponding
examples/andyamls/directories.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/guides/proxysql/update-version/cluster/index.md | Bumps MySQL example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/proxysql/update-version/cluster/examples/sample-mysql.yaml | Bumps MySQL example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/tls/configure/index.md | Bumps MySQL backend example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/proxysql/tls/configure/examples/sample-mysql.yaml | Bumps MySQL backend example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/scaling/vertical-scaling/cluster/index.md | Bumps MySQL example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/proxysql/scaling/vertical-scaling/cluster/example/sample-mysql.yaml | Bumps MySQL example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/scaling/horizontal-scaling/cluster/index.md | Bumps MySQL example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/proxysql/scaling/horizontal-scaling/cluster/examples/sample-mysql.yaml | Bumps MySQL example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/reconfigure/cluster/index.md | Bumps MySQL backend example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/proxysql/reconfigure/cluster/examples/sample-mysql.yaml | Bumps MySQL backend example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/reconfigure-tls/cluster/index.md | Bumps MySQL backend example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/proxysql/reconfigure-tls/cluster/examples/sample-mysql.yaml | Bumps MySQL backend example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/quickstart/mysqlgrp/index.md | Bumps MySQL backend example spec.version to 9.1.0 in both v1 and v1alpha2 snippets. |
| docs/guides/proxysql/quickstart/mysqlgrp/examples/sample-mysql-v1alpha2.yaml | Bumps MySQL v1alpha2 example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/quickstart/mysqlgrp/examples/sample-mysql-v1.yaml | Bumps MySQL v1 example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/monitoring/prometheus-operator/index.md | Bumps MySQL backend example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/proxysql/monitoring/prometheus-operator/examples/mysql.yaml | Bumps MySQL backend example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/monitoring/builtin-prometheus/index.md | Bumps MySQL backend example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/proxysql/monitoring/builtin-prometheus/examples/mysql.yaml | Bumps MySQL backend example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/clustering/proxysql-cluster/index.md | Bumps MySQL backend example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/proxysql/clustering/proxysql-cluster/examples/sample-mysql.yaml | Bumps MySQL backend example manifest spec.version to 9.1.0. |
| docs/guides/proxysql/autoscaler/compute/cluster/index.md | Bumps MySQL backend example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/proxysql/autoscaler/compute/cluster/examples/sample-mysql.yaml | Bumps MySQL backend example manifest spec.version to 9.1.0. |
| docs/guides/mysql/update-version/minorversion/standalone/yamls/standalone.yaml | Bumps MySQL standalone example manifest spec.version to 9.1.0. |
| docs/guides/mysql/update-version/minorversion/standalone/index.md | Bumps MySQL standalone example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/mysql/update-version/majorversion/standalone/yamls/standalone.yaml | Bumps MySQL standalone example manifest spec.version to 9.1.0. |
| docs/guides/mysql/update-version/majorversion/standalone/index.md | Bumps MySQL standalone example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/mysql/update-version/majorversion/group-replication/yamls/group_replication.yaml | Bumps MySQL GR example manifest spec.version to 9.1.0. |
| docs/guides/mysql/update-version/majorversion/group-replication/index.md | Bumps MySQL GR example spec.version to 9.1.0 in the guide snippet. |
| docs/guides/mysql/configuration/podtemplating/yamls/mysql-misc-config.yaml | Bumps MySQL podtemplating example manifest spec.version to 9.1.0. |
| docs/guides/mysql/configuration/podtemplating/index.md | Bumps MySQL podtemplating example spec.version to 9.1.0 in the guide snippet. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Visit the preview URL for this PR (updated for commit d6a8d8e): https://kubedb-v2-hugo--pr850-myversion-lncbf1y7.web.app (expires Tue, 28 Apr 2026 12:28:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943 |
Signed-off-by: Neaj Morshad <neaj@appscode.com>
Signed-off-by: Bonusree <bonusreedatta820@gmail.com>
Signed-off-by: Bonusree <bonusreedatta820@gmail.com>
bef3799 to
c3a852a
Compare
Neaj-Morshad-101
left a comment
There was a problem hiding this comment.
@Bonusree Please check these
Signed-off-by: Bonusree <bonusree@appscode.com>
sheikh-arman
left a comment
There was a problem hiding this comment.
use mysql version v8.4.8 instead of v9.1.0?
Signed-off-by: souravbiswassanto <saurov@appscode.com>
Signed-off-by: Tamal Saha <tamal@appscode.com>
Why not v9.1.0? |
Version 8.4.* belongs to the stable release series, whereas 9.1.0 is part of the innovation series. Since we are updating the documentation, it would be more appropriate to recommend a stable version to users |
Signed-off-by: Bonusree <bonusree@appscode.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 30770553 | Triggered | MySQL Credentials | 7cdab00 | docs/guides/mysql/clustering/innodb-cluster/index.md.bak | View secret |
| 30770556 | Triggered | Generic CLI Secret | 7cdab00 | docs/guides/mysql/backup/stash/standalone/index.md.bak | View secret |
| 30770551 | Triggered | Generic CLI Secret | 7cdab00 | docs/guides/mysql/initialization/using_script.md.bak | View secret |
| 30770554 | Triggered | Generic Database Assignment | 7cdab00 | docs/guides/mysql/clustering/remote-replica/index.md.bak | View secret |
| 25884160 | Triggered | Generic Password | 7cdab00 | docs/guides/mysql/concepts/database/index.md.bak | View secret |
| 30770558 | Triggered | MySQL Credentials | 7cdab00 | docs/guides/mysql/clustering/semi-sync/index.md.bak | View secret |
| 591529 | Triggered | Generic Password | 7cdab00 | docs/guides/mysql/clustering/remote-replica/index.md.bak | View secret |
| 30770550 | Triggered | Generic Password | 7cdab00 | docs/guides/mysql/initialization/using_script.md.bak | View secret |
| 30770556 | Triggered | Generic CLI Secret | 7cdab00 | docs/guides/mysql/backup/stash/standalone/index.md.bak | View secret |
| 30770549 | Triggered | Generic Password | 7cdab00 | docs/guides/mysql/concepts/database/index.md.bak | View secret |
| 30770557 | Triggered | MySQL Credentials | 7cdab00 | docs/guides/mysql/clustering/remote-replica/index.md.bak | View secret |
| 30770555 | Triggered | Generic Password | 7cdab00 | docs/guides/mysql/backup/stash/standalone/index.md.bak | View secret |
| 30770552 | Triggered | MySQL Credentials | 7cdab00 | docs/guides/mysql/clustering/group-replication/index.md.bak | View secret |
| 30770555 | Triggered | Generic Password | 7cdab00 | docs/guides/mysql/backup/stash/standalone/index.md.bak | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
No description provided.