Repository navigation
Route Log in a base's domain errors through DomainError [patch] - #205
Open
matt-edmondson wants to merge 1 commit into
Open
matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
Log(x, newBase) threw ArgumentOutOfRangeException directly with the raw PreciseNumber as its actual value, so reading .Message formatted it in fixed point: an extreme argument threw OverflowException, and Log(-1e-100000, 2) carried a 100,087-character message. Both checks now build the exception through DomainError like every other domain check. Fixes #202 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW4B4xxTAPzAHBD4zKk
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202
What changed
Log(x, newBase, significantDigits)threwArgumentOutOfRangeExceptiondirectly for a non-positivexornewBase, passing the rawPreciseNumberas the actual value. Reading.Messagethen rendered it in fixed point, which throwsOverflowExceptionfor an exponent like-2147483648and produces a 100,087-character message for-1e-100000. Both checks now go throughDomainError, as CLAUDE.md requires of every domain check.Tests
PreciseNumberDomainErrorTests.TestDomainErrorMessageIsShortForAnExtremeExponentgains four rows: an extreme badx(-1e-2147483648,-1e-100000), an extreme badnewBase(-1e-2147483648), and the three-argument overload with-1e2147483647. All four fail without the fix.TestLogInABaseNamesTheArgumentOutsideTheDomainnow expectsActualValueto be the rendered"-2E+000", as the other domain errors carry.Generated by Claude Code