Repository navigation
Ignore a run of trailing NULs in Parse, as decimal and double do [patch] - #194
Merged
Merged
Conversation
Text from a fixed-size or NUL-padded buffer ends with '\0' characters, which the BCL parsers drop. Parse and TryParse now drop one trailing run of them before anything else, under every style, unless the text is nothing but NULs. NULs anywhere else, or followed by white space, are still errors. Fixes #193 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW4sJAUyKbe8WkeBPVB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193
What changed
Parse(ReadOnlySpan<char>, NumberStyles, IFormatProvider?), which everyParse/TryParseoverload goes through, now calls a newTrimTrailingNulsbeforeTrimAllowedWhite. It drops the run of'\0'that ends the text, the waySystem.Number's trailing-zeros check does:NumberStyles.Noneincluded, so it doesn't depend onAllowTrailingWhite"1e3 \0"loses its NUL and then its spaceTests
PreciseNumberParseTrailingNulTestschecks each case againstdecimal.TryParsewith the same style, throughParseandTryParseand through both the string and span overloads:"5\0"(None and Float),"1.5\0\0\0","1e3 \0","12345\0…"(Integer),"-0.25\0""1.5\0 ","\0 5","\0","\0\0\0","5 \0"(None),"5\01"With the fix reverted, all 6 accepted cases fail. Full suite: 598 passed.
Generated by Claude Code