Repository navigation
Create a lightweight tag with --no-sign so tag.gpgSign cannot open an editor [patch] - #210
Merged
Merged
Conversation
… editor [patch] With tag.gpgSign=true git tries to sign a lightweight tag, which turns it into an annotated tag that needs a message, so git opens an editor and fails with "There was a problem with the editor". The tag builder now passes --no-sign when no message is given. Annotated tags still follow the host's signing preference. Fixes #183 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KLFPeLz9EhDwj3AmatpfG6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183
What was wrong
With
tag.gpgSign=true, git ignores a request for a lightweight tag and tries to make a signed annotated tag. A signed tag needs a message, so git opens an editor, andCreateTag(name).ExecuteAsync()throwsGitCommandExceptionwith "There was a problem with the editor". That message says nothing about signing.Change
Annotating(...)),GitTagCreateBuildernow emits--no-signbefore--end-of-options. Annotated tags are left alone, so a user's signing preference still applies to them.CreateTag(name)vector contains--no-sign, and theCreateTag(name).Annotating(msg)vector does not.tag.gpgSign=truein the temp repository's local config,CreateTag(name)succeeds, andTags()reports a non-annotated tag at HEAD's commit.Verification
dotnet testpassed 802 of 802.GitTagCreateBuilderand the tag tests, but in separate hunks, so either can merge first.🤖 Generated with Claude Code
https://claude.ai/code/session_01KLFPeLz9EhDwj3AmatpfG6
Generated by Claude Code