chore: bump @types/node from 22.19.17 to 22.20.1 - #46
Conversation
|
Claude finished @dependabot[bot]'s task in 1m 35s —— View job Dependency review:
|
| Location | Value |
|---|---|
package.json engines.node |
>=22 |
manifest.json compatibility.runtimes.node |
>=22.0.0 |
README.md:18 |
Node.js ≥ 22 |
ci.yml:20 matrix |
['22', '24'] |
update-catalog.yml:27 |
'22' |
So this doesn't trip the "raising the Node floor means moving these together" rule in CLAUDE.md.
Risk assessment
@types/node ships type declarations only — nothing here can change runtime behaviour, and the only plausible failure mode for a DefinitelyTyped minor is a narrowed signature producing a fresh tsc error under strict: true. That didn't happen: CI is green (build + test + .mcpb smoke test) on both Node 22 and 24. skipLibCheck: true also caps the blast radius to declarations the code actually references.
The referenced Node API surface is small and long-stable — node:fs (readFileSync/writeFileSync), node:path (join/dirname), node:url (fileURLToPath), all in scripts/ plus test/version.test.ts. src/ imports no node: builtins at all, only globals like process.env in src/config.ts.
One pre-existing nuance (not introduced by this PR)
^22.0.0 combined with a floor of >=22 makes the floor-tracking guarantee approximate at the minor level: @types/node 22.20 describes APIs added across the whole Node 22 lifetime, so tsc will happily accept something introduced in, say, Node 22.12 even though engines permits 22.0.0. That gap widens slightly with every 22.x minor.
It's harmless today because nothing in src/ touches a node: builtin, and it's arguably the intended tradeoff (pinning ~22.0.0 would mean no security/bugfix type updates at all). Worth being aware of rather than acting on — flagging it only because dependabot.yml's comment frames the rule as exact.
Separately: tsconfig.json sets include: ["src"], so scripts/ and test/ are never type-checked by npm run build — the files that do use node: builtins are the ones tsc doesn't inspect. Also pre-existing and out of scope here.
Suggested follow-up
None required for this PR. If you want the floor guarantee to be real rather than approximate, the check worth adding someday is a tsc pass over scripts/ and test/ (a tsconfig.check.json with a wider include), so type regressions in the Node-API-using code surface in CI.
· branch
0925ea7 to
eb5ce15
Compare
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.19.17 to 22.20.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 22.20.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
eb5ce15 to
30c5cc5
Compare
Bumps @types/node from 22.19.17 to 22.20.1.
Commits