Skip to content

fix(gitlab): record a commit with no author as empty, not " <>" #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbevc1 merged 1 commit into from
Oct 25, 2026
Merged

fix(gitlab): record a commit with no author as empty, not " <>" #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/gitlab/commit_mapping_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,3 +135,14 @@ func TestGitlabMRRefs(t *testing.T) {
require.Equal(t, "feature-branch", head)
require.Equal(t, "main", base)
}

// A commit with no author is recorded with an empty author, not " <>". One
// part is enough to keep the format.
func TestCommitFromGitlabCommit_MissingAuthorIsEmpty(t *testing.T) {
c := commitFromGitlabCommit(&gitlab.Commit{ID: "abc1230000000000000000000000000000000000"}, "my-branch")
require.Equal(t, "", c.Author)
c = commitFromGitlabCommit(&gitlab.Commit{ID: "abc1230000000000000000000000000000000000", AuthorName: "Steve Tooke"}, "my-branch")
require.Equal(t, "Steve Tooke <>", c.Author)
c = commitFromGitlabCommit(&gitlab.Commit{ID: "abc1230000000000000000000000000000000000", AuthorEmail: "tooky@kosli.com"}, "my-branch")
require.Equal(t, " <tooky@kosli.com>", c.Author)
}
7 changes: 6 additions & 1 deletion internal/gitlab/gitlab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,15 @@ func commitFromGitlabCommit(commit *gitlab.Commit, branch string) types.Commit {
if commit.AuthoredDate != nil {
timestamp = commit.AuthoredDate.Unix()
}
// A commit with no author is recorded as "", not " <>".
author := ""
if commit.AuthorName != "" || commit.AuthorEmail != "" {
author = fmt.Sprintf("%s <%s>", commit.AuthorName, commit.AuthorEmail)
}
return types.Commit{
SHA: commit.ID,
Message: commit.Message,
Author: fmt.Sprintf("%s <%s>", commit.AuthorName, commit.AuthorEmail),
Author: author,
Timestamp: timestamp,
Branch: branch,
URL: commit.WebURL,
Expand Down
Loading