Repository navigation
Layout F: packs never span types (#68, which merged into upload-packs, onto main) - #71
Merged
Merged
Conversation
tefkah
added a commit
that referenced
this pull request
Oct 21, 2026
tefkah
added a commit
that referenced
this pull request
Oct 21, 2026
This was referenced Oct 21, 2026
tefkah
added a commit
that referenced
this pull request
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#68 was merged into
upload-packs14 seconds after #64 was squash-merged from it, so the type cuts never reachedmain. This is #68's one commit (f332ec9) cherry-picked ontomain, unchanged.upload-packs, this branch differs only by Layout F: reads in fewer round trips #66, whichupload-packsnever had.0027_push_pack_types(push_packs.record_type, nullable), after Layout F: uploads write records straight into packs; runs carry their places #64's0026.The review and the details are on #68. #69 and #70 follow on this branch.