Skip to content

Strip quotes from parsed package names - #156

Merged
dbanty merged 1 commit into
knope-dev:mainfrom
thinkalpha:fix/quoted-package-names
Nov 7, 2026
Merged

dbanty merged 1 commit into
knope-dev:mainfrom
thinkalpha:fix/quoted-package-names

Conversation

@bytenik

@bytenik bytenik commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Changeset files generated by the JavaScript tooling quote package names, such as "@scope/package": patch. The parser currently keeps those delimiters in PackageName, so consumers cannot match these entries to the package's unquoted name.

Strip one matching pair of single or double quotes when parsing package names. Quoted and unquoted entries then contribute to the same release. Consume front-matter lines independently of the number of unique package names so duplicate normalized keys preserve the summary and retain last-entry-wins behavior.

This changes the parsed names exposed by the public API. A major changeset documents the compatibility change, and the format documentation describes quoted names.

Follows the parser-level fix suggested in knope-dev/knope#2051 (comment).

Validation:

  • All 12 tests pass with cargo test --locked.
  • The quoted-name and normalized-duplicate regressions fail against the original parser.
  • cargo clippy --locked --all-targets -- -D warnings, cargo +nightly fmt --check, and git diff --check pass.

@bytenik
bytenik marked this pull request as ready for review October 23, 2026 14:58
@bytenik

bytenik commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@dbanty how do you feel about this one?

Comment thread src/change.rs Resolved
Comment thread tests/change.rs Resolved

@dbanty dbanty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dbanty dbanty changed the title fix: strip quotes from parsed package names fix!: strip quotes from parsed package names Nov 7, 2026
@dbanty dbanty changed the title fix!: strip quotes from parsed package names Strip quotes from parsed package names Nov 7, 2026
@dbanty
dbanty merged commit 2b02ad9 into knope-dev:main Nov 7, 2026
4 checks passed
@knope-bot-test knope-bot-test Bot mentioned this pull request Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants