Security: suppress unfixable rsa advisory, verify all 2026 CVEs already patched#137
Merged
bashandbone merged 3 commits intomainfrom Mar 27, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/knitli/thread/sessions/24d4648c-84ed-457b-821d-3f740c0ba67b Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix 8 security vulnerabilities in astral-tokio-tar
Security: suppress unfixable rsa advisory, verify all 2026 CVEs already patched
Mar 27, 2026
Contributor
Reviewer's Guide.cargo/audit.toml is added to configure cargo-audit to ignore the known, currently-unfixable RUSTSEC-2023-0071 advisory affecting the rsa crate, with in-file justification documenting why the project is not exploitable and when to re-evaluate. Flow diagram for handling the rsa RUSTSEC-2023-0071 advisoryflowchart TD
Start["Start security audit"] --> CheckDeps["Resolve dependency graph"]
CheckDeps --> RsaPath["rsa present via recoco-core → sqlx → sqlx-mysql"]
RsaPath --> CheckAdvisory["Check RUSTSEC for rsa"]
CheckAdvisory --> HasAdvisory{RUSTSEC-2023-0071 present?}
HasAdvisory -->|No| CleanReport["No rsa advisory, audit passes"]
HasAdvisory -->|Yes| UpstreamFix{Upstream patch available?}
UpstreamFix -->|Yes| RequireUpgrade["Require dependency upgrade to patched version"]
RequireUpgrade --> FailAudit["Audit fails until fixed"]
UpstreamFix -->|No| ConfigIgnore{Is advisory listed in .cargo/audit.toml ignore?}
ConfigIgnore -->|No| ReportIssue["Create/keep failing CI security issue"]
ConfigIgnore -->|Yes| Suppress["Ignore RUSTSEC-2023-0071 with documented justification"]
Suppress --> AuditPass["Audit passes despite known, non-exploitable rsa issue"]
ReportIssue --> End["End"]
CleanReport --> End
FailAudit --> End
AuditPass --> End
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds repository-level cargo-audit configuration to suppress an unpatchable RustSec advisory (rsa Marvin Attack) so scheduled security scans don’t continuously raise noise, while confirming other flagged advisories are already resolved via Cargo.lock.
Changes:
- Add
.cargo/audit.tomlwith an ignore entry forRUSTSEC-2023-0071plus rationale (aligning withdeny.toml’s existing ignore). - Document transitive dependency path and re-evaluation guidance for the suppression.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Adam Poulemanos <89049923+bashandbone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security audit flagged 8 vulnerabilities. 7 are already resolved in
Cargo.lock; the remaining one (rsaMarvin Attack) has no upstream patch and needs explicit suppression in bothcargo-denyandcargo-audittooling.Vulnerability Status
astral-tokio-taraws-lc-sysrustls-webpkirsaChanges
.cargo/audit.toml(new): SuppressesRUSTSEC-2023-0071forcargo-audit, matching the existingdeny.tomlignore entry. Without this, the scheduled workflow creates a new issue on every run for an advisory with no fix. Justification:rsaenters the graph viarecoco-core → sqlx → sqlx-mysql; Thread doesn't use MySQL or expose RSA private-key operations to network timing observation.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.
Summary by Sourcery
Configure security auditing to suppress an unpatchable rsa crate advisory while keeping other 2026 vulnerabilities verified as already resolved.
Bug Fixes:
Enhancements: