Skip to content

fix(autoscaling): duplicated "the" in register.go doc-comment#16600

Open
oab24413gmai wants to merge 1 commit into
knative:mainfrom
oab24413gmai:fix/duplicated-the-in-autoscaling-register-comment
Open

fix(autoscaling): duplicated "the" in register.go doc-comment#16600
oab24413gmai wants to merge 1 commit into
knative:mainfrom
oab24413gmai:fix/duplicated-the-in-autoscaling-register-comment

Conversation

@oab24413gmai
Copy link
Copy Markdown

One-line typo fix in pkg/apis/autoscaling/register.go: "// GroupName is the the public autoscaling group name. This is used for annotations, labels, etc." → "// GroupName is the public autoscaling group name. This is used for annotations, labels, etc.". No code/behavior change.

Signed-off-by: Mira Sato 275437409+oab24413gmai@users.noreply.github.com

Signed-off-by: Mira Sato <275437409+oab24413gmai@users.noreply.github.com>
@linux-foundation-easycla
Copy link
Copy Markdown

CLA Not Signed

@knative-prow knative-prow Bot requested review from dprotaso and skonto May 14, 2026 06:13
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 14, 2026

Welcome @oab24413gmai! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 14, 2026

Hi @oab24413gmai. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oab24413gmai
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linkvt
Copy link
Copy Markdown
Member

linkvt commented May 15, 2026

Hi @oab24413gmai ,
thanks for the PR, make sure you complete the contributors license agreement (CLA) linked in the CI status checks here.

/lgtm
/ok-to-test

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 15, 2026
@linkvt
Copy link
Copy Markdown
Member

linkvt commented May 15, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants