Skip to content

fix: honor builder configured in func.yaml - #4033

Open
pmeida wants to merge 1 commit into
knative:mainfrom
pmeida:fix/ci-honor-func-yaml-builder
Open

fix: honor builder configured in func.yaml#4033
pmeida wants to merge 1 commit into
knative:mainfrom
pmeida:fix/ci-honor-func-yaml-builder

Conversation

@pmeida

@pmeida pmeida commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Fix func config ci ignoring the builder set in func.yaml.FUNC_BUILDER in the generated workflow now reflects build.builder when configured
  • Validate explicit builder values against the known set; unknown values now produce a clear error instead of generating a broken workflow

/kind bug

Fixes #4031

Release Note

`func config ci` now respects the builder configured in `func.yaml`. Previously, `FUNC_BUILDER` in the generated GitHub Actions workflow was always derived from the runtime, silently overriding any `build.builder` value set by the user.

Docs

@pmeida
fix: honor func.yaml builder in CI workflow generation
b517d44 
The generated GitHub Actions workflow always determined FUNC_BUILDER
from the runtime, silently ignoring any builder configured in func.yaml.
This made it impossible for library consumers to force a specific
builder without patching the generated YAML after the fact.

f.Build.Builder is now threaded through the workflow generator. When
set, it takes precedence over the runtime default. Runtime validation
still runs regardless, so unsupported runtimes are rejected even when
an explicit builder is provided. Explicit builder values are also
validated against the known set.
@knative-prow knative-prow Bot added kind/bug Bugs size/L 🤖 PR changes 100-499 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Sep 1, 2026
@knative-prow

knative-prow Bot commented Sep 1, 2026

Copy link
Copy Markdown

Hi @pmeida. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmeida pmeida changed the title config ci: honor builder configured in func.yaml fix: honor builder configured in func.yaml Sep 1, 2026
@knative-prow

knative-prow Bot commented Sep 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pmeida
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk
@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees

No one assigned

Labels

kind/bug Bugs needs-ok-to-test 🤖 Needs an org member to approve testing size/L 🤖 PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

config ci: builder configured in func.yaml is ignored in generated workflow

1 participant

@pmeida