[release-1.23] fix: source func CLI version from build ldflags

[knative-prow-robot]

This is an automated cherry-pick of #4029

`func config ci` now sources the func CLI version used in generated GitHub Actions workflows from the binary's build-time version (set via ldflags), instead of a hardcoded string. Dev builds between releases emit the nearest real release tag by stripping the git describe suffix.

/kind bug

[matejvasek]

Note: this analysis was generated by an AI assistant (Claude).

Why CI is failing

The real failure is the Prow check unit-tests_func_release-1.23. The other red checks are unrelated infra/flakes (see below).

Root cause

TestNewConfigCICmd_WritesWorkflowFileToFSWithCorrectYAMLStructure (cmd/config_ci_int_test.go:86) fails:

assertion failed: missing 'version: knative-v1.23.0' in:
   ...
   version: knative-v1.23.1

The test asserts the generated workflow contains version: + github.DefaultFuncCliVersion (the compiled-in constant, knative-v1.23.0), but the emitted value is knative-v1.23.1.

This is a direct consequence of this PR. The config ci command now sources the version from build ldflags:

FuncCliVersion: gitDescribeSuffix.ReplaceAllString(version.Kver, "")

The integration test drives the real command, so the emitted version now depends on version.Kver, which the Makefile injects from git describe --tags --match 'knative-*'. In Prow's checkout (full history + tags), that resolves to knative-v1.23.1 (the latest tag on release-1.23); the regex only strips the -N-gHASH suffix, leaving 1.23.1, which doesn't equal the hardcoded default 1.23.0.

Why the GitHub-Actions "Unit Tests (ubuntu-latest)" check passes for the same test: actions/checkout is shallow and fetches no tags, so git describe yields nothing → version.Kver is empty → the code falls back through setEmptyFieldsToDefaults to DefaultFuncCliVersion (1.23.0), which matches. So the test is now environment-dependent — it only passes when the build's git-describe version happens to equal the compiled-in default.

Suggested fix

Make the test robust to the build-injected version instead of hardcoding the default. Either:

• set version.Kver to a known value in the test (e.g. "" to force the default fallback), or
• compute the expected version in the test the same way the code does (strip the suffix from version.Kver, fall back to DefaultFuncCliVersion).

Unrelated red checks

• style / Golang / Lint — golangci-lint hit a typecheck error because it couldn't download a module: go.opentelemetry.io/otel@v1.44.0: read "https://proxy.golang.org/...": stream error ... INTERNAL_ERROR. Transient network failure; a re-run should clear it.
• E2E - Runtimes (node) and E2E - Config CI GitHub Workflows — both fail in the deploy step with failed to get credentials: loading registries configuration "/etc/containers/registries.conf": mixing sysregistry v1/v2 is not supported. A runner/cluster config problem, not this PR.

[matejvasek]

/approve
/lgtm

[matejvasek]

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment