hack: remove redundant exit-code check after go run in install.sh#9002
hack: remove redundant exit-code check after go run in install.sh#9002Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
'set -o errexit' is already active, so a non-zero exit from 'go run' terminates the script automatically. The manual '$? -ne 0' check is dead code that adds noise without adding safety.
knative-prow
bot
added
the
area/test-and-release
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
bot
added
size/XS
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Removes dead-code error handling from hack/install.sh by relying on set -o errexit (already enabled) to stop the script when go run fails, aligning with the behavior described in #9001.
Changes:
- Removed the manual
$?exit-code check after the Kubernetes versiongo runinvocation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #9001
Summary
if [[ $? -ne 0 ]]block aftergo runinhack/install.shset -o errexitis already active; the manual check is dead code.