hack: quote dirname substitution and REPO_ROOT_DIR in release.sh#8992
hack: quote dirname substitution and REPO_ROOT_DIR in release.sh#8992Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
Unquoted command substitutions and variables break on paths containing
whitespace. Quote $(dirname "$0") and ${REPO_ROOT_DIR} to handle
paths with spaces correctly.
knative-prow
bot
added
the
area/test-and-release
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
bot
added
the
size/XS
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
the
needs-ok-to-test
There was a problem hiding this comment.
Pull request overview
This PR hardens hack/release.sh against paths containing whitespace by ensuring the script invocation and copy destination don’t undergo unintended word-splitting, addressing issue #8991.
Changes:
- Quote the
dirnamecommand substitution used to locate and rungenerate-yamls.sh. - Quote
${REPO_ROOT_DIR}in thecpdestination so repo paths with spaces work correctly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #8991
Summary
$(dirname "$0")to handle script paths with spaces${REPO_ROOT_DIR}in thecpdestination to prevent word-splittingUnquoted command substitutions and variable expansions break when paths contain whitespace.