Skip to content

fix: race condition in delete & watch wait - #2262

Open
dsimansk wants to merge 1 commit into
knative:mainfrom
dsimansk:pr/fix-delete-watch
Open

fix: race condition in delete & watch wait#2262
dsimansk wants to merge 1 commit into
knative:mainfrom
dsimansk:pr/fix-delete-watch

Conversation

@dsimansk

Copy link
Copy Markdown
Contributor

Description

Changes

  • fix: race condition in delete & watch wait

Reference

Fixes #

Release Note

* fix: race condition in delete & watch wait

For CI to pass
/hold

@knative-prow knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2026
@knative-prow

knative-prow Bot commented Aug 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2026
@knative-prow
knative-prow Bot requested a review from dprotaso August 20, 2026 14:10

@knative-prow knative-prow Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsimansk: 0 warnings.

Details

In response to this:

Description

Changes

  • fix: race condition in delete & watch wait

Reference

Fixes #

Release Note

* fix: race condition in delete & watch wait

For CI to pass
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.86%. Comparing base (c3374b4) to head (9bf82ab).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2262      +/-   ##
==========================================
- Coverage   71.88%   71.86%   -0.02%     
==========================================
  Files         233      233              
  Lines       13535    13526       -9     
==========================================
- Hits         9730     9721       -9     
  Misses       2999     2999              
  Partials      806      806              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dsimansk

Copy link
Copy Markdown
Contributor Author

/test integration-tests_client_main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant