Fix Discord webhook implementation: move to per-response design, resolve editorconfig violations#1
Open
Fix Discord webhook implementation: move to per-response design, resolve editorconfig violations#1
Conversation
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Discord webhook support for notifications in mod
Add Discord webhook support for notification responses
Feb 2, 2026
…onfig violations Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Copilot
AI
changed the title
Add Discord webhook support for notification responses
Fix Discord webhook implementation: move to per-response design, resolve editorconfig violations
Feb 3, 2026
kln581
reviewed
Feb 4, 2026
| /** | ||
| * Send as a Discord webhook message. | ||
| */ | ||
| DISCORD("🪝"); |
kln581
reviewed
Feb 4, 2026
| /** | ||
| * Not validated. | ||
| */ | ||
| Response(boolean enabled, String string, Type type, int delayTicks, int cooldownTicks) { |
Owner
There was a problem hiding this comment.
Response(boolean enabled, String string, Type type, int delayTicks, int cooldownTicks, String webhookUrl) {
kln581
reviewed
Feb 4, 2026
| silent | ||
| ); | ||
|
|
||
| return new Response( |
Owner
There was a problem hiding this comment.
return new Response(enabled, string, type, delayTicks, cooldownTicks, webhookUrl).validate();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous implementation stored webhook URL globally in Config.java, forcing all Discord responses to share one endpoint. Also violated editorconfig line length limits (>100 chars) in multiple files.
Changes
Design fix: Per-response webhook URLs
webhookUrlfrom Config.java to Response.javaEditorConfig compliance
Code cleanup
webhookUrlin Response.validate()Localization
Example
GUI displays two fields for Discord responses: message content (left) and webhook URL (right).
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
maven.fabricmc.net/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4G -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.