Skip to content

Fix Discord webhook implementation: move to per-response design, resolve editorconfig violations#1

Open
Copilot wants to merge 9 commits intomc1.21.1from
copilot/add-discord-webhook-support
Open

Fix Discord webhook implementation: move to per-response design, resolve editorconfig violations#1
Copilot wants to merge 9 commits intomc1.21.1from
copilot/add-discord-webhook-support

Conversation

Copy link

Copilot AI commented Feb 2, 2026

Previous implementation stored webhook URL globally in Config.java, forcing all Discord responses to share one endpoint. Also violated editorconfig line length limits (>100 chars) in multiple files.

Changes

Design fix: Per-response webhook URLs

  • Moved webhookUrl from Config.java to Response.java
  • Each Discord response now configures its own webhook endpoint
  • Removed global Discord enable/disable toggle from Detection tab
  • GUI shows message + webhook URL fields side-by-side (follows CommandKeys pattern)

EditorConfig compliance

  • Fixed 5 line length violations in DiscordWebhookHandler.java
  • Fixed 1 violation in MessageUtil.java
  • All Discord-related code now ≤100 chars per line

Code cleanup

  • Removed 34 lines from Config.java (fields, constructor params, deserializer)
  • Removed 48 lines from DetectionList.java (Discord entry UI)
  • Added null validation for webhookUrl in Response.validate()
  • Restored emoji icon from "D" to "🪝" (consistent with existing Unicode enum)

Localization

  • Removed obsolete Detection tab strings from all language files
  • Updated Discord response tooltip to reflect per-response design

Example

// Response configuration (saved per-notification)
{
  "type": "DISCORD",
  "string": "Player mentioned in chat",
  "webhookUrl": "https://discord.com/api/webhooks/...",
  "delayTicks": 0
}

GUI displays two fields for Discord responses: message content (left) and webhook URL (right).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • maven.fabricmc.net
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4G -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 4 commits February 2, 2026 22:58
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Discord webhook support for notifications in mod Add Discord webhook support for notification responses Feb 2, 2026
@kln581 kln581 marked this pull request as ready for review February 3, 2026 07:18
Copilot AI and others added 3 commits February 3, 2026 20:08
…onfig violations

Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Co-authored-by: kln581 <79673692+kln581@users.noreply.github.com>
Copilot AI changed the title Add Discord webhook support for notification responses Fix Discord webhook implementation: move to per-response design, resolve editorconfig violations Feb 3, 2026
/**
* Send as a Discord webhook message.
*/
DISCORD("🪝");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "D" for discord

/**
* Not validated.
*/
Response(boolean enabled, String string, Type type, int delayTicks, int cooldownTicks) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response(boolean enabled, String string, Type type, int delayTicks, int cooldownTicks, String webhookUrl) {

silent
);

return new Response(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return new Response(enabled, string, type, delayTicks, cooldownTicks, webhookUrl).validate();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants