Repository navigation
ci: use the latest Node.js patch release on every run - #112
Merged
Merged
Conversation
The workflows named exact Node.js versions (22.23.4, 24.22.1 and 26.12.1) so that a runner with an older release of the line in its tool cache would not be used. An exact version stays where it is put: each Node.js release needs another change like #111 to move it, and until then CI and the release jobs keep running the previous one. Each actions/setup-node step now asks for the major of its job (22.x, 24.x or 26.x in the test matrix, 26.x everywhere else) with check-latest: true. setup-node then resolves the newest release of that line from its versions manifest, downloads it when the cached one is older, and logs "Resolved as '<version>'". The major line is unchanged and still moves only by an edit here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
actions/setup-nodestep now takes the newest Node.js release of its major line, instead of an exact version that has to be raised by hand.Why
The exact versions (22.23.4, 24.22.1 and 26.12.1, from #111) kept a runner from using an older release of the line from its tool cache. But an exact version stays where it is put: each Node.js release needs another pull request like #111, and until one lands, CI and the release jobs keep running the previous release, a security release included.
What changed
node-versionis the major of its job (22.x,24.xor26.xin the test matrix,26.xeverywhere else), withcheck-latest: true, in all 8 setup-node steps (ci.yml,pages.ymlandrelease.yml). Withcheck-latest, setup-node resolves the newest release of the line from its versions manifest, downloads it when the cached one is older, and logsResolved as '<version>'.Verification
node-versionandcheck-latestin the setup-node steps, every workflow equalsmain— job names, triggers, permissions and the other steps. The same check fails when a job name is changed.Resolved asthe newest release of its line on nodejs.org (22.23.4,24.22.1or26.12.1) and downloaded it. Thequalityjobs keep their names and ran 1136 tests on each of 22, 24 and 26, as onmain.pages.ymlandrelease.ymlchange the same way; they first run when those workflows next run.🤖 Generated with Claude Code