ISSUE-36: Refactor commentions.js and suggestion.js for improved mention handling#53
Open
navneetrai wants to merge 2 commits intomainfrom
Open
ISSUE-36: Refactor commentions.js and suggestion.js for improved mention handling#53navneetrai wants to merge 2 commits intomainfrom
navneetrai wants to merge 2 commits intomainfrom
Conversation
d0e0957 to
b0f016b
Compare
|
Can anyone help me how I can get this pr with composer instead of last version to test if this is fixing the issue with "noxoua-activity-log" plugin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #36
This pull request improves the robustness and user experience of the mentions feature in the comment editor. The most important changes are focused on safer handling of mention data, simplifying the popup UI for suggestions, and ensuring consistent data formats in both frontend and backend code.
Frontend: Robustness and UI improvements
mentionsandcontentvariables incommentions.jsare always safely initialized to prevent runtime errors and unexpected behavior when rendering the editor. [1] [2]Frontend: Data handling and code simplification
insertMentionfunction and simplified the mention insertion logic to handle mention attributes more robustly and avoid edge-case errors. Also, ensured that items passed to the suggestion component are always arrays.Backend: Consistent mention data
mentions()method inHasMentions.phpto always return a collection, even ifmentionablesis empty, ensuring consistent data format for the frontend and preventing possible errors. [1] [2]